zwave-js
Add Aeotec ZW175-C EU firmware version 1.3
This adds firmware 1.3 for the EU version of the Aeotec Smart Switch 7 which was recently made available. It fixes a rather annoying bug where the change threshold settings don't do anything when the initial value is above 0 (at least for the Watts sensor, though I'm not entirely sure other sensors were not affected as well).
@Aeotec-ccheng Could you please review this PR?
In the IF statement, you may need to change this statement:
"$if": "firmwareVersion < 1.3", "version": "1.3",
to
"$if": "firmwareVersion < 1.3.1", "version": "1.3.1",
Most ZW175-C units are already on V1.3.0 so it may not go through, need the 3rd decimal point to get it to others. Otherwise everything else looks good.
According to the documentation, that is not necessary, patch number 0 is implied (i.e. 1.3.0 and 1.3 are equivalent for the comparison).
As for the current shipping firmware, I recently bought a large number of ZW175-C which were apparently shipped directly from Z-Wave Europe GmbH and so far all were on 1.2.
In the IF statement, you may need to change this statement: "$if": "firmwareVersion < 1.3", "version": "1.3", to "$if": "firmwareVersion < 1.3.1", "version": "1.3.1", Most ZW175-C units are already on V1.3.0 so it may not go through, need the 3rd decimal point to get it to others. Otherwise everything else looks good.
According to the documentation, that is not necessary, patch number
0is implied (i.e.1.3.0and1.3are equivalent for the comparison).As for the current shipping firmware, I recently bought a large number of ZW175-C which were apparently shipped directly from Z-Wave Europe GmbH and so far all were on 1.2.
Ah ok, that was my misunderstanding and probably quickly glanced over it. This is fine then.
Just to clarify, the $if statement is not required per se in this case. If a device is already on firmware 1.3, it won't be offered as an update.
What it achieves though is that the firmware will also not be offered as a downgrade to devices on higher versions. For example if there is a firmware 1.4 in the future and a user desires to downgrade to 1.3 for whatever reason, they won't be able to with the condition firmwareVersion < 1.3.
Not sure if that's what you intended with the other definitions @Aeotec-ccheng ?
@AlCalzone ah ok that makes sense - it isn't but if it can't be helped then that's fine.
@mundschenk-at it isn't necessary to prevent downgrades, but in some cases downgrade of a specific version can cause bricking in some of our devices. This particular device doesn't care so much
IMO allowing users to downgrade where it is supported would be good. After all, users can just download another version from the website anyways, but this service is more convenient and can add guardrails for the cases where users shouldn't downgrade.
IMO allowing users to downgrade where it is supported would be good. After all, users can just download another version from the website anyways, but this service is more convenient and can add guardrails for the cases where users shouldn't downgrade.
OK, I've removed the $if condition.
Thanks! I'll just need a final confirmation from @Aeotec-ccheng then I'll merge.
@AlCalzone Don't see any issues, just confirming everything is good (file URL and hash)