Zachary Ware

Results 34 comments of Zachary Ware

@catap, how can I locally reproduce the failure you're seeing? Can you give me steps starting from however you retrieve the `pycountry` code? Note: these steps need to be unrelated...

Did not get everything I wanted into 24.6.1, but did find a few minutes to get it out the door.

All tests are currently passing everywhere I can run them.

I don't know. Those failures look to me like a mismatch between the code and the data.

Right; we were not surprised to be broken for relying on this, but were disappointed that we had it merged for about a day before `pip` updated and broke it...

They're *supposed* to only be sent when a worker suddenly disappears, not every time the master is restarted (and restarts have become rather more frequent of late :)). I've pinged...

I agree with Victor on pretty much every point here. If we want to keep it to two labels, I'd rather rename `test-with-buildbots` to clarify that it doesn't run refleak...

This is all handled in [buildmaster-config](https://github.com/python/buildmaster-config/blob/19e564278169d4ff760d7a7af0d02118a5f2a984/master/custom/pr_testing.py#L16), it just happens to be using Bedevere's credentials to post the comment.

Hmm, if it's a benchmark runner, do we really want it running a buildbot as well? It seems that would impact its ability to run benchmarks effectively, or would require...

Ok. I'm no expert at benchmarks, so if that configuration is deemed sufficient from that side of things, I'm ok from the buildbot side of things :) Can you create...