owo icon indicating copy to clipboard operation
owo copied to clipboard

added >.< and mutations

Open DrTexx opened this issue 3 years ago • 2 comments

DrTexx avatar Oct 27 '20 08:10 DrTexx

Thanks for the pull request! If I merge this now, approximately 15% of the time it'll pick one of >.> and friends. Every twenty transformations we'd expect one of these to occur about least three times. I'm worried 15% is too high, and it'll get overly repetitive?

What do you think?

zuzak avatar Oct 27 '20 14:10 zuzak

Hmm yeah, that's a good point.

I know it makes things rather more complicated, but what if we were to group all the mutations for a given face, and then instead pick one of those mutations?

For instance, first we randomly decide on a suffix group with a 1/n chance of selecting a given group, then we randomly select a mutation from said group.

For the sake of example, a 2-dimensional array something like this:

const suffixes = [
  ["<.<", ">.<", ">.>"],
  ["xD", "xP", "x3"]
  // ...
]

Also, if we have a suffix that's fairly unique, we could either:

  1. Put each unique suffix into it's own 1 item array; or
  2. Leave it as a string instead of an array, but add a condition before substituting to check if the choice is an array first (and then pick an item within it if it is).

Option 1 is certainly easier for other contributors to understand since a clear pattern is set, however it's a little redundant. Option 2 has less redundancy and is probably more fun to code, however is more complex and encourages a less consistent database structure.

DrTexx avatar Oct 28 '20 00:10 DrTexx