Junfan Zhang

Results 434 comments of Junfan Zhang

Maybe it will. But we could introduce new config to enable debug, default is false.

Got your point. Metric system is better for performance observation. And i think i can invest this topic by submitting some PRs later.

> Could you add some performance results? Should we only modify the critical code? Actually i didn't do any performance test. Just found this optimization while I was browsing spark...

> @zuston From [apache/spark#20119](https://github.com/apache/spark/pull/20119), there has performance issue with NIO's Files API. The performance issue is caused by the default `InputStream.skip` implementation. So i dont replace it in the uniffle...

Any progress? What do i need to do before merging @jerqi

I think we could directly follow the Spark change. Besides, the performance test looks hard. @jerqi

Sorry, maybe you misunderstand my thought. I hope if a spark job needs to do two shuffles, it can use the different shuffle manager. 1. Shuffle-ID-0, use the sortShuffleManager due...

> When we reuse the Shuffle-ID-1, the rss don't have enough server nodes, what will it happen? I think it should fail because the shuffle data is in died server...