joyride icon indicating copy to clipboard operation
joyride copied to clipboard

does not work with jQuery 1.4.4

Open jtnix opened this issue 11 years ago • 8 comments

TypeError: b.replace is not a function: Line 19 of jquery-1.4.4.min.js

I see this also does not work with 1.5.2 and 1.7.something as well.

jtnix avatar May 21 '13 00:05 jtnix

jquery 1.4 is over three years old.

What's the reason for not having the latest jquery? I think that's the real question here.

robhadfield avatar May 21 '13 09:05 robhadfield

It is a legacy installation and I am not free to just upgrade jquery without a full-suite test of the entire app which would take days, although I am sure it will happen one day.

However, until then, how about the devs update the specs for Joyride that it only works on JQuery 1.8 + because it sure looks like that is the case.

jtnix avatar May 21 '13 14:05 jtnix

Line 876, just add ,null :: $(el).on('keydown', null, function( event )

jtnix avatar May 23 '13 02:05 jtnix

From the project homepage:

Updated to jQuery 1.8.2, supports 1.4.2 and up.

davereid avatar Jun 13 '13 23:06 davereid

Same problem with jQuery 1.6.4.
I made change as mentioned @jtnix, now it's working.
With joyride 2.1, it's now on line 883
Thanks :)

ManUtopiK avatar Jun 27 '13 00:06 ManUtopiK

@ManUtopiK can you post a fuller example?

rwinikates avatar Jun 28 '13 20:06 rwinikates

On line 883, simply add "null" $(el).on('keydown', null, function( event )

ManUtopiK avatar Jun 28 '13 21:06 ManUtopiK

I was having the same issue with jQuery 1.6.4, and added null as advised above (but it was on line 840). Thanks for the tip - been scratching my head over this for a while now!

james246 avatar Aug 11 '14 09:08 james246