Neyts Zupan comments

Results 152 comments of


                                            Neyts Zupan

Code formatting

I like enforcing line widths and don't care too much about performance, so I'm gonna go with `nixfmt`! Thanks for the help!

Printing a lot of output can be expensive

Could you make a PR for this?

Hey @tkimnguyen! I just upgraded our intranet to 5.1.2. It turned out to be much easier to use https://github.com/niteoweb/heroku-buildpack-buildout instead, since that gets more love due to us using it...

server url and routes autogeneration

The [test](https://github.com/Pylons/pyramid_openapi3/blob/29f0180a97d9d33cbe65488aee97af8339c120c4/pyramid_openapi3/tests/test_routes.py#L27) does not set `servers`, so it is entirely possible that there is a bug. Can you try changing this test to set `servers` and see if it fails?

Need help with using $refs

I've never personally used multiple `yaml` files, so can't help you with this one, sorry :( That said, I'm very interested in having a working example of this included in...

Add support for extra_format_unmarshallers

This makes sense. Can you prepare a Pull Request with the required changes?

request.openapi_validated does not break non-opeanpi views

Rebased off of latest master, let's get this one merged, finally.

$ref overwrites `nullable` property

The entire `nullable` story seems to have been rewritten in OpenAPI v3.1. This library does not yet support v3.1, but work is in progress: https://github.com/Pylons/pyramid_openapi3/pull/206

Validating `application/x-www-form-urlencoded` request bodies doesn't work

@pepijn-motosumo: now that pyramid_openapi3 supports the latest openapi-core, it is time to revisit this. I constructed a new test based on your PR draft, and it passes fine, so it...

Reconsider API spec autogeneration

The tooling now seems to have come along far enough that we can should be able to do this without too much wheel reinventing, just reusing the tools out there:...