BrowserSelect icon indicating copy to clipboard operation
BrowserSelect copied to clipboard

Browser Select window on top

Open ducmthai opened this issue 4 years ago • 15 comments

Hi,

Currently, when a link is clicked in Office apps and Windows 10 settings send to Browser Select but its window is not in foreground or on top of other program windows. Can we have an option to make it always on top so we don't have to minimize window after window in order to see Browser Select?

Thanks, Jasper

ducmthai avatar Dec 06 '19 03:12 ducmthai

@zumoshi I'm willing to try implementing this. Would you accept such a PR?

octogonz avatar Mar 26 '20 23:03 octogonz

Sure, I'm always happy to accept PR's. Just make it an opt-in option so it's not enabled by default.

zumoshi avatar Mar 26 '20 23:03 zumoshi

@ducmthai Do you remember how to repro this problem? After I upgraded to 1.4.1 it seems to not be happening any more. But it only happened in certain situations -- maybe I'm just not trying the right thing. (?)

octogonz avatar Mar 26 '20 23:03 octogonz

@octogonz Firstly, thanks for jumping in :) Secondly, you can reproduce this behavior with most if not all UWP app. I click a link in Skype UWP or from Settings app BrowserSelect would open but not show up.

ducmthai avatar Mar 27 '20 00:03 ducmthai

I just tested with UWP Skype, OneNote, and Microsoft News. In all cases it seems to correctly switch to the BrowserSelect dialog when a hyperlink is clicked.

@ducmthai Are you using version 1.4.1?

octogonz avatar Mar 27 '20 00:03 octogonz

Yes, I do. I also using Windows Insider slow ring. Don't know if that is the cause?

ducmthai avatar Mar 27 '20 01:03 ducmthai

For me clicking external links in Steam will in 99% of cases put BrowserSelect into the background, with no taskbar icon. It's not a UWP/WinStore app.

Luckz avatar Mar 28 '20 05:03 Luckz

@Luckz Which link are you clicking? I tried clicking this:

Untitled

...and the BrowserSelect.exe window correctly opens in front of the Steam window, with a taskbar icon. In Process Explorer, I see a process tree like this:

Untitled2

I'm using Windows 10 Pro 64-bit build 18363.70. And BrowserSelect is version 1.4.1.

octogonz avatar Mar 29 '20 02:03 octogonz

image

For me it just does not appear in the taskbar; build 18363.592 (and Browser Select 1.4.1). I would assume it's not due to Steam Beta participation: image

This works fine if I instead change my default browser to Browser Chooser 2: image image

Luckz avatar Mar 29 '20 02:03 Luckz

🤔 Hrmm... Unfortunately I don't have time to install a VM with the newer Windows Insider release (at least, not unless we can conclusively prove that it is the cause).

Has anyone else encountered this with regular Windows 10? I'll try to do some more experiments, or try it on some other computers. We need a consistent repro before I can debug it.

octogonz avatar Mar 29 '20 02:03 octogonz

Hi,

I did test it with another laptop running regular Windows 10 and BrowserSelect did pop-up and has a taskbar icon. However, on Windows 10 Insider Slow Ring it behaves like the image below: image

ducmthai avatar Mar 29 '20 22:03 ducmthai

I also get this issue, I didn't investigated the conditions, but I click a link, and ... I learned that I need to search the window somewhere in the background behind my windows ...

adynis avatar Apr 23 '20 11:04 adynis

Is there any update on this issue? If you click a link in an UWP app you will see this behavior.

ducmthai avatar Sep 10 '20 16:09 ducmthai

I have a case where it pops up in the background, and there is no icon in the taskbar. Once I switch to it using alt-tab, the taskbar icon shows up.

I use the npm-dependency-links extension in VS code, which lets you ctrl-click on a package name in package.json to open the npmjs.com page in your browser. I'm pretty sure it doesn't pop in front since I'm holding a key down (I've seen that before on Windows), but the taskbar thing is more annoying. Not a critical bug, obviously, just an annoyance. 😃

gtflip avatar Feb 11 '22 16:02 gtflip

I have a case where it pops up in the background, and there is no icon in the taskbar. Once I switch to it using alt-tab, the taskbar icon shows up.

I use the npm-dependency-links extension in VS code, which lets you ctrl-click on a package name in package.json to open the npmjs.com page in your browser. I'm pretty sure it doesn't pop in front since I'm holding a key down (I've seen that before on Windows), but the taskbar thing is more annoying. Not a critical bug, obviously, just an annoyance. 😃

Out of curiosity, do you have the same issue with my fork? https://github.com/lucasnz/BrowserSelect

I have included this PR, which in theory should resolve this issue: https://github.com/zumoshi/BrowserSelect/pull/80

You could also try the PR authors fork too...

lucasnz avatar Feb 22 '22 18:02 lucasnz