BrowserSelect icon indicating copy to clipboard operation
BrowserSelect copied to clipboard

Brave Browser?

Open MatiasNino-REISYS opened this issue 7 years ago • 4 comments

There's a new browser based on the chrome webkit called Brave (https://brave.com/). It has built-in ad blocking and is built for performance. If possible, please add this browser into the options.

Thanks again for building this app. I've been using it for years now! :)

MatiasNino-REISYS avatar Aug 02 '17 21:08 MatiasNino-REISYS

hello, I don't need to manually add browsers to BrowserSelect. it is designed to get the list of installed browsers automatically from the registry. all the browsers that are available in "Defaults programs" section of the control panel as an option for the default browser, should be listed in browser select automatically.

I installed the browser you mentioned and it seems that it creates a malformed entry in the registry. in the path SOFTWARE\Clients\StartMenuInternet\Brave\shell\open\command, the path for browser's executable is missing. (you can compare it with firefox or chrome to check).

note that the registry key I mentioned is not created by browser select, but is the standard defined by Microsoft on how browsers should introduce themselves to the OS. you can read more on it here.

I suggest you open an issue with them to fix it, which would make it show up on browser select without doing anything extra.

but in the mean time, you can manually add it to the registry to get it to show up. to do this follow these steps:

  1. press Win+R
  2. type regedit and press enter
  3. go to HKEY_CURRENT_USER -> Software -> Clients -> StartMenuInternet -> Brave -> shell -> open -> command
  4. double click on (Default) on the right panel
  5. paste the full path of brave.exe in the opened dialogue (e.g. C:\Users\USERNAME\AppData\Local\brave\Brave.exe )
  6. click OK and close regedit

image

image

zumoshi avatar Aug 05 '17 16:08 zumoshi

Hi All, I've just started using v1.3.9 of the app. Brave appears for me automatically, that is not a problem. But if I click on it, and a) Brave is not running yet, then it starts in two separate windows, one showing my last session, and the other one showing my pinned sites and the link I wanted to open in a tab, but that tab is not the selected one. b) Brave is running, but only in the window from my last session, because I closed the other one (see a)), then by selecting Brave, its window pops up again, but it does not open the link at all. I am running Brave v0.22.669 on Win10. Thank you for your help in advance!

Babber avatar Apr 28 '18 07:04 Babber

hi, thanks for your report @Babber . your issue seems to be related to this one: https://github.com/brave/browser-laptop/issues/9193 i'll release a fix for it with 1.4.0 when i fixed #35 and #36

but for the time being you can use the attached version. it still has the issue of opening a new window if brave is not running, but it can open tabs correctly if it was running before. BrowserSelect-v1.3.10-prerelease.zip

also in the future please make a separate issue for unrelated problems.

zumoshi avatar Apr 28 '18 08:04 zumoshi

OK, thank you, @zumoshi ! And sorry for posting this issue here, it is indeed not the same.

Babber avatar Apr 28 '18 08:04 Babber