BrowserSelect icon indicating copy to clipboard operation
BrowserSelect copied to clipboard

Installer issues with version 1.3.4

Open BGMcoder opened this issue 9 years ago • 3 comments

When I use the installer I got from Snapfiles, it wants to install BrowserSelect to this location: C:\users\username\appdata\local\BrowserSelect but this isn't the normal place, really. I would rather see it deployed to C:\Program Files (x86)\BrowserSelect which is the normal place. Or at least maybe the user can choose?

With the installer, if I manually enter the path as C:\Program Files(x86)\BrowserSelect then the application creates a new folder at c:\program files (x86)| <--yes, it adds the | and then creates the BrowserSelect folder within that directory

BGMcoder avatar Sep 07 '16 15:09 BGMcoder

I chose to install the BrowserSelect in AppData folder so users without administrative permissions can also install it in a restricted environment. google chrome also installs itself inside AppData folder.

but the pipe (|) character being added when you change the location manually is weird. I'm not that good with NSIS (the installer that BrowserSelect uses), perhaps you can take a look at it and submit a pull request ?

if you could put a radio button choice to install for all users (inside program files) or current user only (inside AppData) I would merge that, but I don't want to remove the choice to install it in AppData.

also, you should keep in mind that currently, the installer adds browserSelect's registry keys to HKCU rather than HKLM (which require administrative permission). if we add an option to install in program files we should also change the registry locations.

zumoshi avatar Sep 07 '16 16:09 zumoshi

I was guessing your reason for using appdata, but I always dislike it when programs try to install to other places. Yeah, I don't like Google either.
I've never used NSIS - I've used Inno though. I know that with Inno you can check to see if the user has admin rights and then do things like change the installation path.
I appreciate the invite, but I'm not really interested in learning NSIS (I'm rather stacked up with work already); I'm sorry, but I'm not the man for this job. But I love to see folks write new software, so I thought I would at least contribute some of my testing notes.

BGMcoder avatar Sep 07 '16 16:09 BGMcoder

I think it should install:

  • to %ProgramFiles% (32-bit system) or %ProgramFiles(x86)% (64-bit system) if run as administrator.
  • to %LocalAppData% if run as user.

NSIS can detect how setup is run (admin or user). I also agree with the original post.

dogancelik avatar Sep 19 '16 20:09 dogancelik