zulipbot icon indicating copy to clipboard operation
zulipbot copied to clipboard

Wrongful assignation when explaining how Zulipbot works

Open johanehinger opened this issue 2 years ago • 4 comments

I believe this is a bug. When explaining how to claim an issue using Zulipbot in the Github comments (i.e. the claim command) Zulipbot recognizes this as an attempt to claim the issue, even though it is expressed inside of a code snippet like this:

```console  
@zulipbot claim 
```  

Which in turn obviously produces the following statement:

@zulipbot claim 

To see this unexpected behavior in action you can have a look at the issue #19834 in the Zulip main project. Or see the screenshot below.

image

johanehinger avatar Sep 27 '21 16:09 johanehinger

Hello @johanehinger!

Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

zulipbot avatar Sep 27 '21 16:09 zulipbot

Hello @johanehinger!

Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

zulipbot avatar Sep 27 '21 16:09 zulipbot

It almost appears that Zulipbot is trying to prove my point here inside this discussion thread. Simply pointing out this unexpected behavior gets misinterpreted as an attempt to claim the issue. Let me know what you think of this.

johanehinger avatar Sep 27 '21 16:09 johanehinger

We handle codeblock command escaping here: https://github.com/zulip/zulipbot/blob/main/src/events/issue.js#L40 It looks like since you're including a language tag (console) after the 3 starting backticks, zulipbot fails to recognize the command as being inside a command.

Can probably switch to a regex to fix this.

synicalsyntax avatar Oct 01 '21 08:10 synicalsyntax