zulipbot icon indicating copy to clipboard operation
zulipbot copied to clipboard

Features for the zulip-mobile repository.

Open jackrzhang opened this issue 6 years ago • 12 comments

Reported in chat here.

I haven't been able to add labels to issues in both the server and mobile repositories; see https://github.com/zulip/zulip/issues/10500, which I opened 6 days ago, and https://github.com/zulip/zulip-mobile/issues/2962, which I opened today.

jackrzhang avatar Sep 18 '18 00:09 jackrzhang

@zulipbot add "bug"

jackrzhang avatar Sep 18 '18 00:09 jackrzhang

Oh, it just worked on this repository. Hmm..

jackrzhang avatar Sep 18 '18 00:09 jackrzhang

I just tried again to add labels to https://github.com/zulip/zulip-mobile/issues/2962 (I've deleted the comment) - it still does not work there.

jackrzhang avatar Sep 18 '18 00:09 jackrzhang

@jackrzhang zulip-mobile isn't listed as an active repository in the configuration file, so all commands are ignored in that repository. I believe @borisyankov requested that we remove it from active repositories to disable issue inactivity checks.

synicalsyntax avatar Sep 18 '18 01:09 synicalsyntax

Thanks for explaining! I think the actual issue I have in mind, then, is a new feature that allows for inactivity checks to be disabled for specific repositories. There's a lot of lost utility in disabling the entire bot to avoid one of the features, and I'd still like to have zulipbot enabled for the mobile repository.

I'm not very familiar with the Github API. Would something of the sort be possible? If it is, I can open a new issue for it.

jackrzhang avatar Sep 18 '18 01:09 jackrzhang

Yea, I don't think there's currently a way to disable inactivity checks for a certain repo.

lonerz avatar Sep 18 '18 20:09 lonerz

@jackrzhang Well, right now we just ignore payloads from any inactive repositories, so we can just delete those lines to continue accepting commands on those repositories. It's a two line change. Would this be acceptable?

synicalsyntax avatar Sep 18 '18 21:09 synicalsyntax

For more context on chat.zulip.org, here's the #mobile-team topic for zulipbot.

jackrzhang avatar Sep 18 '18 22:09 jackrzhang

@gnprice @jainkuniya

jackrzhang avatar Sep 18 '18 22:09 jackrzhang

Based on the conversation in chat, here's a tentative list of zulipbot features that are, or would be, useful for the mobile team:

  • The claim and abandon commands and the automated in progress label
  • The add and remove commands, which I try to use frequently
  • An option to disable inactivity checks, though I feel the same as @gnprice in that I'm torn on this
  • Automated size labeling - I imagine 5 categories: XS, S, M, L, XL
  • An option to disable team mentions

jackrzhang avatar Sep 18 '18 22:09 jackrzhang

Thanks for letting me know your desired settings! This fits more in of our long-term goal of refactoring the configuration system to allow creating per-repository configuration files (after we add codebase coverage), so I'm not sure how fast I can implement this. I'll be sure to update the mobile team as soon as is done though :)

synicalsyntax avatar Sep 20 '18 17:09 synicalsyntax

Adding one more:

I will like is: when any issue is mentioned in the commit msg or PR (like Fix: #1234) then change in progess label on the issue to pr ready.

Use case: Sometimes I am pretty much excited to review PR of some exciting issues, but i am not sure, whether PR for this issue is submitted to not (as label is still in progress). So I have to narrow to all those issues to find a PR for that issue.

(https://chat.zulip.org/#narrow/stream/243-mobile-team/subject/zulipbot/near/645150)

jainkuniya avatar Sep 20 '18 19:09 jainkuniya