zulip icon indicating copy to clipboard operation
zulip copied to clipboard

frontend: Change button inside anchor tag to only anchor element.

Open abhigyank opened this issue 7 years ago • 7 comments
trafficstars

The buttons contained in anchor elements are changed by creating a valid link style that looks like the buttons we have now.

improves: #6126

abhigyank avatar Feb 13 '18 11:02 abhigyank

If the approach looks okay, I'll do the changes in other files as well.

abhigyank avatar Feb 13 '18 11:02 abhigyank

@zulipbot label "needs review"

abhigyank avatar Feb 13 '18 11:02 abhigyank

@vaidap @brockwhittaker can one of you review this?

timabbott avatar Feb 16 '18 16:02 timabbott

Why all inside of <div> elements? If you need block styling then just make the links block styled with a class.

brockwhittaker avatar Feb 16 '18 18:02 brockwhittaker

@brockwhittaker used <div> to be able to center-align the links and use inline-block property to have the width of the link box defined by the text size. This worked best.

abhigyank avatar Feb 17 '18 13:02 abhigyank

ping @brockwhittaker .

abhigyank avatar Feb 22 '18 13:02 abhigyank

Heads up @abhigyank, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Apr 08 '18 03:04 zulipbot