zulip
zulip copied to clipboard
frontend: Change button inside anchor tag to only anchor element.
The buttons contained in anchor elements are changed by creating a valid link style that looks like the buttons we have now.
improves: #6126
If the approach looks okay, I'll do the changes in other files as well.
@zulipbot label "needs review"
@vaidap @brockwhittaker can one of you review this?
Why all inside of <div> elements? If you need block styling then just make the links block styled with a class.
@brockwhittaker used <div> to be able to center-align the links and use inline-block property to have the width of the link box defined by the text size. This worked best.
ping @brockwhittaker .
Heads up @abhigyank, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.