zulip icon indicating copy to clipboard operation
zulip copied to clipboard

Published 20 hours ago • verified publisher icon zulip

Add support for @online/@here mentions.

Open umairwaheed opened this issue 8 years ago • 12 comments

Fixes #2183

umairwaheed avatar Mar 17 '17 10:03 umairwaheed

Automated message from Dropbox CLA bot

@umairwaheed, it looks like you've already signed the Dropbox CLA. Thanks!

smarx avatar Mar 17 '17 10:03 smarx

Still need to add tests to increase code coverage.

umairwaheed avatar Mar 17 '17 12:03 umairwaheed

@zulipbot abandon

sampritipanda avatar Mar 17 '17 15:03 sampritipanda

@timabbott please review.

umairwaheed avatar Mar 20 '17 10:03 umairwaheed

Hello @zulip/server-markdown members, this pull request references an issue with the "area: markdown" label, so you may want to check it out!

zulipbot avatar Mar 20 '17 13:03 zulipbot

@timabbott, this one is ready for review as well.

umairwaheed avatar Mar 22 '17 04:03 umairwaheed

@umairwaheed am I right in understanding that this would obviate #2453?

brainwane avatar Apr 05 '17 19:04 brainwane

This is a rebase of that; closed the older issue.

timabbott avatar Apr 05 '17 20:04 timabbott

@umairwaheed did you mean to close this? I think we actually do still want to implement this.

timabbott avatar Aug 16 '17 04:08 timabbott

Nope :). I was trying to clean my local repo. Reopened.

umairwaheed avatar Aug 16 '17 04:08 umairwaheed

Heads up @umairwaheed, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Aug 16 '17 05:08 zulipbot

Heads up @umairwaheed, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Nov 21 '17 00:11 zulipbot

Closing in favor of the more current https://github.com/zulip/zulip/pull/16964 for this issue.

timabbott avatar Jan 15 '24 01:01 timabbott