zulip icon indicating copy to clipboard operation
zulip copied to clipboard

Published 20 hours ago • verified publisher icon zulip

Use Ionic search icon and feathericon close icon for search.

Open evykassirer opened this issue 2 years ago • 2 comments

image image

evykassirer avatar Feb 22 '23 21:02 evykassirer

The screenshots look fine to me.

alya avatar Feb 22 '23 22:02 alya

I just removed merged conflicts.

Alya has given it a look, and it's ready for CZO deploy by @timabbott.

This PR has very minimal visual change and is a nice prep for the bigger search bar change.

evykassirer avatar Mar 15 '23 02:03 evykassirer

I think we can skip a chat.zulip.org deployment for this and just merge it to main if it looks good to us. The search icon looks almost the same as the old one, so I think that's very low risk. The "X" looks potentially a bit large to me; how was the size for it selected?

image

timabbott avatar Mar 16 '23 00:03 timabbott

Hello @zulip/design members, this pull request was labeled with the "redesign" label, so you may want to check it out!

zulipbot avatar Mar 23 '23 05:03 zulipbot

Great call! I (just now) used the technique Vlad taught me to get it the right size with viewing the overlay on Figma

image

evykassirer avatar Mar 23 '23 21:03 evykassirer

No remaining issues on my end, next step is Tim looking again for merging.

evykassirer avatar Mar 23 '23 21:03 evykassirer

Merged, thanks @evykassirer!

timabbott avatar Mar 24 '23 23:03 timabbott