zulip icon indicating copy to clipboard operation
zulip copied to clipboard

settings: Fix bot edit form for bots without owner.

Open sahil839 opened this issue 2 years ago • 5 comments

Trying to open bot edit form for a bot without owner raises an error. bot-without-owner

This is most probably some error in initializing dropdown_list_widget.

sahil839 avatar Feb 21 '23 06:02 sahil839

Hello @zulip/server-settings members, this issue was labeled with the "area: settings (admin/org)" label, so you may want to check it out!

zulipbot avatar Feb 21 '23 06:02 zulipbot

@zulipbot claim.

Ujjawal3 avatar Feb 21 '23 11:02 Ujjawal3

@zulipbot claim.

Ujjawal3 avatar Feb 21 '23 11:02 Ujjawal3

@sahil839 after digging into the relevant codebase I found that this issue is not because of absence of owner but rather because all these were cross realm bots. With some little modifications edit bot form can be shown but should I also allow user to change the bot settings from the edit form? I think if we have to allow changing the settings from the form than it will involve some significant changes.

Ujjawal3 avatar Feb 22 '23 20:02 Ujjawal3

Thanks for investigating. Therea has been discussion here for not showing the edit buttons for these bots.

sahil839 avatar Feb 25 '23 12:02 sahil839