onboarding: Add emoji reactions to Welcome Bot.

[raghupalash]

Updated:

For the first message the Welcome Bot does following:

1. Reacts with a 🎉
2. Sends an additional message that says: "I'm happy to help you out! 🎉 ", before sending the appropriate reply. Tests have been updated to reflect these changes.

Fixes #20023.

Correct

Incorrect

[zulipbot]

Hello @zulip/server-emoji, @zulip/server-onboarding members, this pull request was labeled with the "area: emoji", "area: onboarding" labels, so you may want to check it out!

[raghupalash]

Hey @alya, is this how we want this to be?

[alya]

Thanks for working on this @raghupalash ! What I had in mind for this issue was using emoji reactions as a way to demonstrate that feature, rather than adding emoji to the text of the bot's reply.

[raghupalash]

Oops, will fix that.

[raghupalash]

I have fixed this, also updated the gifs(look at the start of this thread).

[raghupalash]

BTW I just realized that adding emoji reactions does two things:

1. It gives user a feeling of accomplishment if there response is correct.
2. But most importantly, it eases user to a Zulip feature, that we can react with emojis on a message.

Awesome idea @alya! Were there any more reasons behind this idea that I missed?

[alya]

Thanks for implementing this, @raghupalash !

Playing around with it, it feels like it's actually too much to have the reactions for every message.

Can we try changing it so that for the first message to Welcome Bot (no matter what it is) the bot:

1. Reacts with a 🎉
2. Sends an additional message that says: "I'm happy to help you out! 🎉 ", before sending the appropriate reply.

That should be enough to give a bit of an intro to emoji reactions without making it overwhelming. Sorry for the extra work!

[alya]

BTW I just realized that adding emoji reactions does two things:

1. It gives user a feeling of accomplishment if there response is correct.
2. But most importantly, it eases user to a Zulip feature, that we can react with emojis on a message.

Awesome idea @alya! Were there any more reasons behind this idea that I missed?

Yeah, that's what I was thinking. :)

[raghupalash]

These are the responses now on the first messages.

Correct

Incorrect

[raghupalash]

I'm keeping the previous commit around, when we are solid about this change and want to move forward with it, I'll remove it from the history.

@alya here are the changes.

[alya]

@raghupalash sorry I missed your update somehow. Looks good to me!

@timabbott can you take a look?

[raghupalash]

I have squashed the previous commit for easier merge.

[raghupalash]

I have separated the changes into 3 different commits @timabbott to best of my understanding, thanks for the advice! Ready for review.

[zulipbot]

Heads up @raghupalash, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

[zulipbot]

Hello @raghupalash, it seems like you have referenced #20023 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #20023..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

To learn how to write a great commit message, please refer to our guide.