zulip icon indicating copy to clipboard operation
zulip copied to clipboard

css: Alert message padding

Open manavdesai27 opened this issue 4 years ago • 4 comments

This PR is for issue #19153.

Testing plan:

I have changed padding of p tags in alert using .alert p in the app_components.css file. I have tested it manually.

GIFs or screenshots:

Before:

before

After:

after

manavdesai27 avatar Jul 23 '21 10:07 manavdesai27

I think this CSS selector is way too broad -- we have alert elements all over the app, and this will change all of them in unpredictable ways.

timabbott avatar Jul 23 '21 18:07 timabbott

So, what do you suggest @timabbott ? Can you give me some ideas on how to proceed?

manavdesai27 avatar Jul 23 '21 19:07 manavdesai27

I'd recommend some combination of learning about CSS selectors, reading the codebase for what style we use, finding the CSS for this specific widget, debugging using the browser inspector why this alert looks bad and others might not, and then proposing a revised fix. (I can't recommend a specific fix without doing that work myself)

timabbott avatar Jul 23 '21 21:07 timabbott

Heads up @manavdesai27, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Feb 24 '23 18:02 zulipbot