zulip icon indicating copy to clipboard operation
zulip copied to clipboard

markdown: Add quoted emoticon parser function. (Issue #17789)

Open schultzh opened this issue 3 years ago • 1 comments

#17789

In this approach, any emoticon found in "fenced code" is not converted into an emoji. This includes when quoting another user where the initial message includes an emoticon, as to preserve the contents and meaning of the original message.

Testing plan: Manual tests are shown below. If this is an acceptable approach to this issue, testing can be added.

GIFs or screenshots:

Screen Shot 2021-05-10 at 9 31 00 PM

schultzh avatar May 11 '21 01:05 schultzh

Heads up @schultzh, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Sep 07 '21 16:09 zulipbot