zulip icon indicating copy to clipboard operation
zulip copied to clipboard

Remove stream_data from the cluster.

Open showell opened this issue 3 years ago • 5 comments

showell avatar Apr 16 '21 18:04 showell

Thanks for working on this @showell! I posted a batch of comments; otherwise lgtm.

timabbott avatar Apr 16 '21 22:04 timabbott

The first two commits here should be no-brainers to merge (just node test cleanup). And the third can probably also be merged (since no comments on it).

showell avatar Apr 16 '21 22:04 showell

(Merged the first two; https://github.com/zulip/zulip/pull/18193#discussion_r615143892 is about the third).

timabbott avatar Apr 17 '21 16:04 timabbott

(rebased off of latest master)

showell avatar Apr 17 '21 17:04 showell

Heads up @showell, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Sep 07 '21 16:09 zulipbot