zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

Test zulip-terminal with new hl_lines markdown feature

Open timabbott opened this issue 3 years ago • 3 comments

We're close to merging https://github.com/zulip/zulip/pull/16984, which will add support for the pygments hl_lines feature (being able to highlight lines in a markdown code block).

We should test how that new feature looks in the terminal app, and if it's ugly, fix it.

As a sidenote, is it useful to document features like this in the API changelog?

timabbott avatar Mar 26 '21 19:03 timabbott

I assume this issue is primarily to ensure we don't have a problem with it rendering badly, as opposed to it being rendered properly?

My recollection is that we ignore unknown rendered tags and don't currently style code as it's pretty challenging given we're already styling the rest of the UI, though this has been suggested once or twice in the past.

Provisionally we could take the test case examples from the PR to test against, right?

Since this affects the format of the data we (could) get from the server, I'd certainly say it belongs in the API changelog.

neiljp avatar Mar 26 '21 20:03 neiljp

@rsashank This could be good additional test data for the code 'snippets' PR?

neiljp avatar Apr 22 '24 21:04 neiljp

@neiljp Thanks for bringing this up, I'll look into this :)

rsashank avatar Apr 22 '24 22:04 rsashank