zulip-terminal
zulip-terminal copied to clipboard
zulip
workflows: Add github action checking emoji data matching with server.
The workflow uses CRON time syntax to schedule the check daily at a specific time. In case of a mismatch in fetched data and existing data, the check would fail with exit status: Emoji data not up-to-date.
[unrelated]: Corrects a couple of diffs :)
Fixes #912
Wouldn't it be better if it's checked in every push and PR? If something breaks in a certain pr, it would be very difficult to identify it. Also, the main branch is supposed to be stable and we are all using it during development, so this goes against that.
I second @Ezio-Sarthak's approach here. A CRON job might be better suited as these change infrequently as mentioned in the issue. We wouldn't have to run this as frequently as on every push and PR, also considering the frequency of that is highly variable. I presume the check is meant to be more general. Since the emoji list is auto-generated and not meant to be modified manually, the chance of something breaking in a PR should be significantly low.
@Abhirup-99 I initially had a thought of doing so, but as mentioned by Neil in the issue, this (that is, change in emoji data) should be infrequent, and so a regular check could be enough. Also, since we have some workflows triggering already (specially codeql), having one more with every push would be a bloat to the repo.
@prah23 Thanks for the clarification 👍
PS - The PR is open for reviews :)
@neiljp Thanks for the review!
The notification of check on czo topic is a pretty awesome idea! I'll see if I could make a script to send a message to czo #zulip-terminal > Unicode emoji sync with server if that's possible :) Also, do we have to notify in czo only if there's a change in data?
Heads up @Ezio-Sarthak, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.
