zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

Minimize length of stream box during compose based on available space & maximum stream length

Open neiljp opened this issue 4 years ago • 20 comments

Currently the stream box can be quite wide; we spread the boxes between the available width.

While topic length can vary, we should be able to find some way to determine a smaller length using urwid's features based on what we know about the maximum stream length at the time.

Good related features to consider

  • if we can/should limit the width of the 'topic edit' box while editing (edit-one, edit-later, edit-all messages in a topic)
  • fix the length of the stream box while editing, if the stream cannot be changed (pending message moving feature)

I've labelled this as a good first issue initially as this would be good to help someone new to this to get to know urwid and the core UI, but this may be challenging or trickier than I expect and involve digging a little to find the right combination of spacing, so that this works over a wide range of window widths.

neiljp avatar Feb 02 '21 05:02 neiljp

@zulipbot claim

cyberShaw avatar Feb 02 '21 19:02 cyberShaw

Welcome to Zulip, @cyberShaw! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot avatar Feb 02 '21 19:02 zulipbot

Hello @cyberShaw, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 10 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 4 days.

If you've decided to work on something else, simply comment @zulipbot abandon so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Zulip!

zulipbot avatar Feb 13 '21 01:02 zulipbot

@zulipbot claim

Sickaada avatar Feb 15 '21 14:02 Sickaada

Hello @silentC1C4D4, it looks like someone has already claimed this issue! Since we believe multiple assignments to the same issue may cause some confusion, we encourage you to search for other unclaimed issues to work on. However, you can always reclaim this issue if no one is working on it.

We look forward to your valuable contributions!

zulipbot avatar Feb 15 '21 14:02 zulipbot

@zulipbot abandon

cyberShaw avatar Feb 15 '21 17:02 cyberShaw

Hello @jalajcodes, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

zulipbot avatar Feb 17 '21 16:02 zulipbot

@zulipbot claim

Sickaada avatar Feb 17 '21 17:02 Sickaada

Welcome to Zulip, @silentC1C4D4! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot avatar Feb 17 '21 17:02 zulipbot

Hello @jalajcodes, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

zulipbot avatar Feb 18 '21 09:02 zulipbot

@zulipbot claim

b-thebest avatar Mar 10 '21 00:03 b-thebest

Welcome to Zulip, @b-thebest! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot avatar Mar 10 '21 00:03 zulipbot

@zulipbot claim

as2539-ctrl avatar Mar 17 '21 20:03 as2539-ctrl

Welcome to Zulip, @as2539-ctrl! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot avatar Mar 17 '21 20:03 zulipbot

@zulipbot claim

suzaram3 avatar Mar 30 '21 18:03 suzaram3

Welcome to Zulip, @suzaram3! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot avatar Mar 30 '21 18:03 zulipbot

is the issue still unresolved?

notlelouch avatar Jan 08 '24 17:01 notlelouch

@notlelouch You could look through open PRs, but there is no merged fix - try running the development version of ZT on a wide terminal and you should be able to see the problem.

neiljp avatar Jan 09 '24 19:01 neiljp