zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

Style the message with current logged in user's mentions (like webapp)

Open Ezio-Sarthak opened this issue 4 years ago • 6 comments

We could modify the color of the message box if it contains the current session's logged in user's mention like (red) in web app.

Ezio-Sarthak avatar Jan 01 '21 05:01 Ezio-Sarthak

@zulipbot add "enhancement"

Ezio-Sarthak avatar Jan 01 '21 05:01 Ezio-Sarthak

@zulipbot add "further discussion required"

Ezio-Sarthak avatar Jan 01 '21 06:01 Ezio-Sarthak

My opinion would be to leave it as is since the red for @ mentions seems to be good enough for distinguishing from other messages.

mkp6781 avatar Apr 01 '21 17:04 mkp6781

I'm not sure if I'd agree to that. The mentions could be red for all users, right?

Ezio-Sarthak avatar Apr 02 '21 09:04 Ezio-Sarthak

The title of the issue could be misleading. I guess what Sarthak meant is to style those messages which contain the current user's mention(i.e. the user using ZT) - just like the webapp. The red for @ mentions are used for highlighting all username and distinguishing it from the rest of the message.

@Ezio-Sarthak Perhaps amending the title/description to be a bit more apt, would be better?

zee-bit avatar Apr 02 '21 09:04 zee-bit

@zee-bit thanks for clarifying. I've updated the title/description accordingly. Apologies for confusion. Is it appropriate now?

Ezio-Sarthak avatar Apr 02 '21 12:04 Ezio-Sarthak