zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

boxes: Add edit countdown timer and modify edit view for stream and PM.

Open prah23 opened this issue 4 years ago • 5 comments

Added edit_countdown_timer which runs asynchronously for as long as the edit compose box is open. The timer refreshes every minute while the time remaining is over 1 minute, and every second otherwise. The stream_box_edit_view has been modified to display the timer. private_box_edit_view has been added as a separate view for editing private messages.

Fixes #727 and #752.

Screenshot: image

prah23 avatar Dec 30 '20 21:12 prah23

@zulipbot remove "further discussion required"

prah23 avatar Dec 31 '20 07:12 prah23

@zulipbot remove "has conflicts"

prah23 avatar Jan 09 '21 11:01 prah23

@prah23 Could you please remove the merge commit and rebase against upstream instead?

neiljp avatar Jan 13 '21 16:01 neiljp

@neiljp Thank you for the review! I apologize for the merge commit, I am aware of Zulip being rebase-based, I noticed a couple of conflicts and was trying to resolve them and I merged them accidentally. I was in the midst of trying to sort it out and fix linting right now, while you were reviewing it. I will make the changes as discussed and push clean commits.

prah23 avatar Jan 13 '21 17:01 prah23

Heads up @prah23, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Jan 30 '21 20:01 zulipbot