zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

Checks if a user's package versions are consistent with those specified in requirements.

Open sundargs2000 opened this issue 4 years ago • 4 comments

Hey guys. This is in reference to #545. Please go through and let me know if a different implementation was expected. I'll write the tests as well.

sundargs2000 avatar Dec 03 '20 11:12 sundargs2000

I left comments on the issue regarding the approach, so I'm marking this as needing update based on the discussion there. We can discuss the implementation here.

neiljp avatar Dec 21 '20 02:12 neiljp

@neiljp Since we can't import from setup.py, the only way I found out was to use ast to get install_requires. Is that fine or is there any other method?

sundargs2000 avatar Jan 02 '21 14:01 sundargs2000

@sundargs2000 I'm not sure of the best approach here; it's an interesting problem, but you might consider other issues for now.

neiljp avatar Jan 07 '21 01:01 neiljp

Heads up @sundargs2000, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Apr 17 '24 23:04 zulipbot