zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

search_box: Improved search box query handler.

Open aryanshridhar opened this issue 4 years ago • 2 comments

Earlier , The query typed in search box is erased when the user navigates to a new stream . As suggested by @neiljp here , Added a extra keybinding of meta /( alt /) which retains the search query and carries it forward whenever the user changes narrows .

It includes :

  • If the user wants to perform a non-sticky search across narrows , the usual keybinding of / would make the job done .
  • But , if user prefers for a sticky-search , activating the searchbox with meta / is useful.

Non-Sticky Search : (/)

2

Sticky Search :(meta /)

3


Would love an review @neiljp .

aryanshridhar avatar Nov 05 '20 19:11 aryanshridhar

@aryanshridhar Do you intend to continue this soon? I don't believe we have an issue for this?

neiljp avatar Jan 22 '21 01:01 neiljp

Heads up @aryanshridhar, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Aug 30 '21 23:08 zulipbot