zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

Add secure notifications for WSL

Open neiljp opened this issue 4 years ago • 4 comments

WSL notifications were removed in 0.5.2. We should aim to add back a secure version.

neiljp avatar Aug 09 '20 19:08 neiljp

For reference: ea8321d is the commit that removed notifications on WSL and secured it on Linux & macOS.

zee-bit avatar Mar 28 '21 08:03 zee-bit

@neiljp But, I don't understand the security flaw in WSL notifications. I just tested it myself, and although the notifications work fine, the terminal's display breaks(sort-of), with all the text getting exceedingly small. Is this the reason for removing notifications in WSL or was there some other major security-issue?

PS: There is a feature request for this already filed in WSL's github page here.

zee-bit avatar Mar 28 '21 12:03 zee-bit

The issue is the handling of the necessary quoting, which is/was not clear.

neiljp avatar Apr 05 '21 20:04 neiljp

Hello @zulip/server-notifications members, this issue was labeled with the "area: notifications" label, so you may want to check it out!

zulipbot avatar Mar 21 '22 02:03 zulipbot