zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

Published 20 hours ago • verified publisher icon zulip

Limit rapid keypresses

Open kaustubh-nair opened this issue 4 years ago • 3 comments

This PR solves the rate-limiting issues by due to rapid keypresses by:

  • Preventing concurrent up/down when at the top or bottom of the MessageView.
  • Rate limits pressing of other keys to 15 consecutive presses.

kaustubh-nair avatar Jul 14 '20 21:07 kaustubh-nair

Gave some thoughts in #zulip-terminal>Rate limiting issues.

neiljp avatar Jul 14 '20 22:07 neiljp

Heads up @kaustubh-nair, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Jul 30 '20 21:07 zulipbot

Hmm, good question; I'm not sure what the right server API would be for indicating the rate-limiting structure; maybe a good discussion for #backend.

I'm not sure I understand the situation here -- is the user behavior with ZT that causes it to potentially hit rate limits something we expect users to want to do? The issue may be structurally a UI problem.

timabbott avatar Jul 30 '20 23:07 timabbott