zulip-terminal
zulip-terminal copied to clipboard
zulip
Maintain position in topic list when toggling topic list
When we enter/leave the topic list, we currently reset the focus in the topic list to the top - even if previously it was some distance down the list.
I'd suggest we want to maintain focus instead, perhaps even when moving between different streams and back again? (at least, within one ZT session)
For implementation, this will involve storing the state when last in a stream (if there is any), on changing between stream and topic views in the left panel. Note that topic names and ordering may change between such times, so we should also fall back to an almost match, including if a topic is resolved.
@neiljp i would like to work on this issue as my first issue.can u point me to the directory where changes are needed to be made?
@Subhasish-Behera This will likely be a change in one of the ui_tools/ files, maybe views.py.
I'd suggest generally understanding the logic involved in following from a 'key' (eg. ? for the help menu) to the action, and then which state it updates.
If you need support with getting started, please drop in on chat.zulip.org in #zulip-terminal :)
Welcome to Zulip, @israelsgalaxy! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!
Here's some tips to get you off to a good start:
- Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
- Unwatch this repository, so that you don't get 100 emails a day.
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.
See you on the other side (that is, the pull request side)!
@israelsgalaxy Please check in-progress PRs first; I will look for other issues that need the help-wanted tag, as I think @Subhasish-Behera may still be working on this.
@israelsgalaxy Thanks for showing interest in ZT. I've made substantial progress and am almost finished. Given the progress I've made, I think it would be best for me to wrap this up, and you could work on a different issue.
Sorry if there was some confusion as I don't generally claim any issue .