zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

Inventory styles and ensure they are appropriately used & named

Open neiljp opened this issue 4 years ago • 1 comments

I'm pretty sure that we currently re-use some style names for elements which are un-related (eg. unread counts). This is mostly harmless, though confusing to read in the code, and now that we use more styles it would be useful to have a clearer idea of which are used and for what purposes.

The end result might involve having descriptive comments next to each entry in required_styles (if the names are insufficiently clear, in particular), and possibly changing the names of some styles, perhaps with prefixes.

Looking through the UI code will help find these instances, so this would be good to learn the way the UI works. To ensure that these cases are found, we may be able to use tests, but this may require manual checks - though automating this and having a tool for future use would be beneficial.

neiljp avatar Mar 17 '20 06:03 neiljp

Hello @neiljp, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

zulipbot avatar Apr 11 '20 22:04 zulipbot