zulip-terminal
zulip-terminal copied to clipboard
zulip
Create `users_list` by taking current local time from server insted of user's pc.
If the time on user's pc in not correct, then the users_list will have inconsistent behaviour in terms of showing active/idle/offline users. We can use current local time from server to correct this issue.
Relevant code - https://github.com/zulip/zulip-terminal/blob/master/zulipterminal/model.py#L501
Welcome to Zulip, @Ar9av! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!
Here's some tips to get you off to a good start:
- Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
- Unwatch this repository, so that you don't get 100 emails a day.
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.
See you on the other side (that is, the pull request side)!
Do you want me to use an api like http://worldtimeapi.org/ to fetch the current timestamp and use it in place of time.time ?
I think our website doesn't depend upon pc's local time to indicate active/offline users. You can look into that if it's not too much of a trouble. @neiljp might have other insights.
Hello @Ar9av, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.
You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.
Thanks for your contributions, and hope to see you again soon!
Welcome to Zulip, @kumarnithin164! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!
Here's some tips to get you off to a good start:
- Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
- Unwatch this repository, so that you don't get 100 emails a day.
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.
See you on the other side (that is, the pull request side)!
Should I retrieve time based on the server_url? Or the current location of the user?
Hello @kumarnithin164, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.
You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.
Thanks for your contributions, and hope to see you again soon!
I want to work on this issue.
I think our website doesn't depend upon pc's local time to indicate active/offline users. You can look into that if it's not too much of a trouble. @neiljp might have other insights.
Where can i see this in use in zulip-terminal or in atleast in zulip?
The line @amanagr is referring to is https://github.com/zulip/zulip-terminal/blob/fdd0137c83f5242968e41ec8e745d18fb46d60c0/zulipterminal/model.py#L554. i just wanted to point this out for someone else who would want to work on this after me.
I am actually having such error on my pc, glad to find an issue for the same! Would love to work on the issue! :)
The server time will soon be exposed in the initial data, which will enable resolution of this issue.
@neiljp You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!