zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

Refactor: Improve set_count() behaviour.

Open sumanthvrao opened this issue 5 years ago • 3 comments

This PR makes the set_count behaviour more consistent.

The commits are broken as:

  • Rename a variable in set_count() function for better understanding
  • Extracting and distinguishing (read vs unread) two functions for setting unread_counts in model. This commit also contains how we can now use the two functions in set_count() for setting stream, pm unreads.
  • Improving the reading behaviours for muted messages (Where by we set there unread_counts as well). This commits also sets unread_counts of unread[topics] which we had not done previously.

sumanthvrao avatar Jul 07 '19 04:07 sumanthvrao

@neiljp FYI. Rebased this ;)

sumanthvrao avatar Jul 12 '19 14:07 sumanthvrao

Sure. Sounds reasonable :+1:

sumanthvrao avatar Jul 29 '19 00:07 sumanthvrao

Heads up @sumanthvrao, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Apr 17 '20 00:04 zulipbot