zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

Views/BuddyView: Introduce BuddyView to show Recent PMs and Group PMs.

Open amanagr opened this issue 6 years ago • 9 comments

amanagr avatar Feb 26 '19 09:02 amanagr

buddy_view This is a preview of how buddy list looks now. This is mostly functional and is ready for a spin if anyone wants to try. I would love any feedback on this.

I will add tests for this soon and then reorder some of the commits.

amanagr avatar Feb 28 '19 10:02 amanagr

I don't know why the tests are failing for python 3.4 only??

amanagr avatar Mar 03 '19 08:03 amanagr

@neiljp I have added minimal tests for the functions and this could possibly serve as a v1 for BuddyList. Since this PR is already getting too big, I will add some feature improvements I have in mind along with more robust tests in future PRs. Thanks!

amanagr avatar Mar 04 '19 11:03 amanagr

Thanks @neiljp for the review I will get to them by the end of this week as I am busy with exams.

amanagr avatar Mar 11 '19 09:03 amanagr

I have split the commit as you suggested. As for the fixtures, I can curb them down but I feel they can be useful later as they provide the base for all the group_pm and unread_count related fixtures which were previously missing.

amanagr avatar Mar 16 '19 12:03 amanagr

@neiljp is this ready to merge?

amanagr avatar Mar 23 '19 05:03 amanagr

@punchagan @neiljp I have rebased this PR against master. Let me know your views on this.

amanagr avatar May 15 '19 11:05 amanagr

Codecov Report

Merging #315 into master will decrease coverage by 1.96%. The diff coverage is 64.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
- Coverage   70.38%   68.41%   -1.97%     
==========================================
  Files          12       12              
  Lines        2195     1979     -216     
  Branches      479      440      -39     
==========================================
- Hits         1545     1354     -191     
  Misses        524      524              
+ Partials      126      101      -25
Impacted Files Coverage Δ
zulipterminal/config/keys.py 100% <ø> (ø) :arrow_up:
zulipterminal/ui.py 71.87% <0%> (-3.69%) :arrow_down:
zulipterminal/core.py 49.26% <30%> (-1.21%) :arrow_down:
zulipterminal/ui_tools/views.py 82.37% <66.07%> (-0.4%) :arrow_down:
zulipterminal/helper.py 62.75% <66.66%> (-2.81%) :arrow_down:
zulipterminal/ui_tools/buttons.py 75.22% <85.71%> (-6.3%) :arrow_down:
zulipterminal/ui_tools/boxes.py 53.63% <0%> (-5.73%) :arrow_down:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3b31c8b...aaf5ee1. Read the comment docs.

codecov[bot] avatar Jul 22 '19 12:07 codecov[bot]

Heads up @amanagr, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Apr 17 '20 00:04 zulipbot