zulip-terminal
zulip-terminal copied to clipboard
zulip
Fix issues with message merging (hiding content headers) based on star status
When two messages have identical author and very similar date/time, messages are shown adjacently, without repeating either information. These messages appear 'merged', though will highlight separately when scrolled through.
Starring/unstarring a message should 'split' any merged messages, but currently does not do so reliably. The rationale for this is that the content header applies to the entire (apparent) message, or group of messages, and this includes the star marker.
In addition, if a message is separate, it should not just have a star/no-star status, ie. no repeated author/datetime but a * (or no star); rather, probably the datetime should be repeated.
The code handling this is entirely in the MessageBox class main_view function.
You might find it useful to explore this by checking the current tests, and adding a new or amended test for the situation(s) described in the issue. if you need more clarification, please ask on #zulip-terminal or here.
Hello @shreyamalviya, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.
We look forward to your valuable contributions!
@neiljp, I'd like to work on this but I'm waiting for a review on another PR, so I can't claim this. Could I please be assigned to this issue? Thanks!
@shreyamalviya Let me know if you need reassigning; was this the screenshot PR? Are you still working on that too?
@neiljp, yes, I just have to change that one image as we discussed on czo (#286).
Hello @shreyamalviya, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.
You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.
Thanks for your contributions, and hope to see you again soon!
I would like to work on this issue. Can I please take it up? @zulipbot claim
Welcome to Zulip, @Dishti-Oberai! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!
Here's some tips to get you off to a good start:
- Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
- Unwatch this repository, so that you don't get 100 emails a day.
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.
See you on the other side (that is, the pull request side)!
Hello @Dishti-Oberai, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.
You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.
Thanks for your contributions, and hope to see you again soon!
@Dishti-Oberai You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!
hello my name is rohit @neiljp is the issue still open i want some help
@rohitmishra666 There is an existing PR for this that can be built upon, that @Sushmey expressed interest in, but I've not heard anything for a while from them.
This issue and related PRs have been discussed in # zulip-terminal > Message merging - star status #T1147 (issue #T171) on chat.zulip.org.