zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

Notify on alert words (#1301 rebase + tidy)

Open neiljp opened this issue 2 months ago • 1 comments

What does this PR do, and why?

This takes #1301 and applies some tidying, following through with some of the changes I suggested.

Full notification logic remains incomplete for now, but this takes us closer.

Other than new features in the server, we not take into account various user settings, which affects for example wildcard mentions.

@mounilKshah FYI Since you were involved in reviewing #1301, and I'm only testing this remotely right now.

External discussion & connections

  • [x] Discussed in #zulip-terminal in Alert word handling #T588 #T1301 (originally)
  • [ ] Fully fixes #
  • [ ] Partially fixes issue #
  • [x] Builds upon previous unmerged work in PR #1301
  • [ ] Is a follow-up to work in PR #
  • [ ] Requires merge of PR #
  • [ ] Merge will enable work on #

How did you test this?

  • [ ] Manually - Behavioral changes
  • [ ] Manually - Visual changes
  • [x] Adapting existing automated tests
  • [x] Adding automated tests for new behavior (or missing tests)
  • [x] Existing automated tests should already cover this (only a refactor of tested code)

Self-review checklist for each commit

  • [x] It is a minimal coherent idea
  • [x] It has a commit summary following the documented style (title & body)
  • [x] It has a commit summary describing the motivation and reasoning for the change
  • [x] It individually passes linting and tests
  • [x] It contains test additions for any new behavior
  • [x] It flows clearly from a previous branch commit, and/or prepares for the next commit

neiljp avatar May 14 '24 19:05 neiljp