zulip-terminal
zulip-terminal copied to clipboard
zulip
Add guest user suffix, depending on organization setting
From feature level 216 (Zulip 8.0), realm_enable_guest_user_indicator is present in the response from register (and in events), which should control whether we add a (guest) suffix to users with that role.
The web app UI needs checking for which locations this appears, which likely needs a development environment in order to explore behavior for when this setting is enabled or otherwise.
We should also confirm that
- the suffix wasn't present unconditionally prior to this
- this behaves correctly in a backwards-compatible way
However, this will also need tests, which may need to be feature level (ZFL) dependent.
This is implemented in mobile via zulip/zulip-mobile#5804, and based on the release announcement on chat.zulip.org, hides the guest suffix only when on 8.0+ and the organization has the setting to do so. There are also screenshots that suggest places that will need updating in zulip/zulip-mobile#5809.
Welcome to Zulip, @AnkurPrabhu! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!
Here's some tips to get you off to a good start:
- Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
- Unwatch this repository, so that you don't get 100 emails a day.
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.
See you on the other side (that is, the pull request side)!
Hey @neiljp just wanted to say that i am still working on this issue some of the changes are done and i will raise a pr and if you approve it then i will start with the testing part
@neiljp please take a look at the pr, The tests are failing as I have not fixed them because i wanted to know if my approach is right and also wanted to know other places where the change needs to be done and have missed it . will fix the test with the review changes
@AnkurPrabhu You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!