zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

Support server-customized presence parameters

Open neiljp opened this issue 1 year ago • 4 comments

This is a fairly small migration in Zulip 7.0, server feature level 164 (https://zulip.com/api/changelog).

Quoting the changelog entry:

POST /register: Added the server_presence_ping_interval_seconds and server_presence_offline_threshold_seconds fields for clients to use when implementing the presence system.

Instead of hard-coded constants, we should therefore use these values provided by the server, falling back to the original constants when the server version is lower (when the keys in the response to register-queue are empty).

If tests are added or updated, note that they should likely be parametrized over different feature levels - see other tests which do so for comparisons.

neiljp avatar Aug 03 '23 01:08 neiljp

@zulipbot claim

criticic avatar Dec 13 '23 09:12 criticic

Hello @criticic, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

zulipbot avatar Dec 13 '23 09:12 zulipbot

@zulipbot claim

rsashank avatar Jan 17 '24 16:01 rsashank

@rsashank You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

zulipbot avatar Jan 31 '24 15:01 zulipbot