zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

TRACKING: Migrate internal code to use Direct Message terminology

Open neiljp opened this issue 1 year ago • 28 comments

This is a follow-up to the user-visible #1288, as fixed by #1322.

  • Rename/clarify internal variables; we could dedicate a specific task to this, but it may be more effective to migrate as-needed, where one part of the code is changed at a time, which relates to a particular other change underway
  • Update to follow API changes; these will likely not be rapid, and support the older API for some time in any case

neiljp avatar Mar 21 '23 15:03 neiljp

Hello @zulip/server-refactoring members, this issue was labeled with the "area: refactoring" label, so you may want to check it out!

zulipbot avatar Mar 21 '23 15:03 zulipbot

@zulipbot claim

abdulmoiz37 avatar Mar 28 '23 02:03 abdulmoiz37

Hello @abdulmoiz37!

Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

zulipbot avatar Mar 28 '23 02:03 zulipbot

@zulipbot add "help wanted"

abdulmoiz37 avatar Apr 10 '23 10:04 abdulmoiz37

@zulipbot claim

abdulmoiz37 avatar Apr 10 '23 10:04 abdulmoiz37

Hello @abdulmoiz37, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

zulipbot avatar Apr 10 '23 10:04 zulipbot

Hello @abdulmoiz37, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

zulipbot avatar Apr 11 '23 05:04 zulipbot

Hello @abdulmoiz37, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@zulipbot I would like to work on this issue as well till my other PR's get reviewed.can you assign this to me?

abdulmoiz37 avatar Apr 11 '23 05:04 abdulmoiz37

@zulipbot claim

abdulmoiz37 avatar Apr 11 '23 05:04 abdulmoiz37

Hello @abdulmoiz37, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

zulipbot avatar Apr 11 '23 05:04 zulipbot

@abdulmoiz37 You are welcome to work on this, but it's not a high priority compared to other areas.

As the summary aims to suggest, this may be better achieved by migrating naming when we work on particular areas, one at a time.

neiljp avatar Apr 17 '23 20:04 neiljp

Hello @WladRamos, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

zulipbot avatar May 04 '23 22:05 zulipbot

Hello @WladRamos, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

zulipbot avatar May 04 '23 22:05 zulipbot

@zulipbot claim

mschuler10 avatar May 04 '23 22:05 mschuler10

Welcome to Zulip, @mschuler10! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot avatar May 04 '23 22:05 zulipbot

@PedroQXD You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

zulipbot avatar May 15 '23 03:05 zulipbot

@zulipbot abandon

mschuler10 avatar May 17 '23 17:05 mschuler10

@zulipbot claim

PedroQXD avatar May 17 '23 17:05 PedroQXD

Welcome to Zulip, @PedroQXD! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot avatar May 17 '23 17:05 zulipbot

Hello @neiljp , I was looking into this issue and I have a question. The issue description specifies that only the internal variables need to be renamed, but for this change, I believe it makes sense to also modify the methods headers. How should I proceed?

PedroQXD avatar May 18 '23 01:05 PedroQXD

@zulipbot claim

PedroQXD avatar May 22 '23 23:05 PedroQXD

@zulipbot abandon

PedroQXD avatar May 29 '23 23:05 PedroQXD

@zulipbot claim

WladRamos avatar May 30 '23 00:05 WladRamos

ERROR: Unexpected response from GitHub API.

zulipbot avatar May 30 '23 01:05 zulipbot

@zulipbot claim

WladRamos avatar May 30 '23 01:05 WladRamos

@WladRamos You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

zulipbot avatar Jun 11 '23 03:06 zulipbot