zulip-terminal
zulip-terminal copied to clipboard
zulip
Migrate get_next_unread_pm & tests to model
The equivalent migration for get_next_unread_topic was performed in #1245.
This is a precursor for improving the get_next_unread_pm method.
Please check the steps performed in #1245. Not all will be necessary for this, but careful commit structure will be important to demonstrate changes are pure refactoring steps.
Hello @zulip/server-refactoring members, this issue was labeled with the "area: refactoring" label, so you may want to check it out!
@ifarabi This issue cannot be claimed, as someone else is already working on it. Please see our contributor guide for advice on finding an issue to work on. Thanks!
unfortunately, I am currently not able to work on this issue @ifarabi you can take over from here @zulipbot unclaim
Welcome to Zulip, @ifarabi! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!
Here's some tips to get you off to a good start:
- Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
- Unwatch this repository, so that you don't get 100 emails a day.
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.
See you on the other side (that is, the pull request side)!
if your are not able to resolve this issue @ifarabi,i can help you with it
@neiljp An unexpected family emergency has occurred, so I will need to unassign myself from this task.
Welcome to Zulip, @WladRamos! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!
Here's some tips to get you off to a good start:
- Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
- Unwatch this repository, so that you don't get 100 emails a day.
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.
See you on the other side (that is, the pull request side)!
@WladRamos You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!
is this issue still open ? i see get_next_unread_pm is already in model
It's hard to me to track this down on github, due to force-pushed, I imagine.
It seem indeed that @neiljp directly pushed the required model changes to main in ce9deccc5c4 without a PR. So what is still open is the PR #1395 which seems to have just some changes to tests left.
@Vishnurr2k01 Thanks for the enquiry, and apologies for the delay in replying - indeed this is now in the model :+1:
@zormit I appreciate you tracking this down, and indeed I did a partial merge of that PR. I've marked #1395 as a completion candidate PR, and will mark this as complete, but add #1395 as a useful precursor to working on the rest of #1336.