zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

[WIP] Disable cycling while editing a PM

Open Subhasish-Behera opened this issue 2 years ago • 7 comments

What does this PR do? -> Disables cycling during editing a PM by tab key . -> Shows a warning if one uses tab during editing a PM.

Partial fix for #774

Tested?

  • [X] Manually
  • [X] Existing tests (adapted, if necessary)
  • [x] New tests added (for any new behavior)
  • [X] Passed linting & tests (each commit)

Commit flow

commit 1: changes made to boxes.py commit 2: changes made to test_boxes.py Notes & Questions

Interactions

Visual changes zt1

Subhasish-Behera avatar Jan 04 '23 14:01 Subhasish-Behera

@zulipbot add "PR needs review"

Subhasish-Behera avatar Jan 10 '23 05:01 Subhasish-Behera

Heads up @Subhasish-Behera, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Feb 20 '23 21:02 zulipbot

The new code dosen't need self.reply_keypressed or self.edit_keypressed to track which key triggered the private_box_view as you suggested.

Subhasish-Behera avatar Apr 16 '23 16:04 Subhasish-Behera

@zulipbot add "PR needs review"

Subhasish-Behera avatar Apr 16 '23 21:04 Subhasish-Behera

@Subhasish-Behera Is this ready for another review?

neiljp avatar Sep 09 '23 02:09 neiljp

@Subhasish-Behera Is this ready for another review?

Yep.

Subhasish-Behera avatar Sep 11 '23 14:09 Subhasish-Behera

Heads up @Subhasish-Behera, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Apr 17 '24 23:04 zulipbot