zulip-terminal
zulip-terminal copied to clipboard
[WIP] Disable cycling while editing a PM
What does this PR do?
-> Disables cycling during editing a PM by tab
key .
-> Shows a warning if one uses tab during editing a PM.
Partial fix for #774
Tested?
- [X] Manually
- [X] Existing tests (adapted, if necessary)
- [x] New tests added (for any new behavior)
- [X] Passed linting & tests (each commit)
Commit flow
commit 1: changes made to boxes.py commit 2: changes made to test_boxes.py Notes & Questions
Interactions
Visual changes
@zulipbot add "PR needs review"
Heads up @Subhasish-Behera, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main
branch and resolve your pull request's merge conflicts accordingly.
The new code dosen't need self.reply_keypressed
or self.edit_keypressed
to track which key triggered the private_box_view
as you suggested.
@zulipbot add "PR needs review"
@Subhasish-Behera Is this ready for another review?
@Subhasish-Behera Is this ready for another review?
Yep.
Heads up @Subhasish-Behera, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main
branch and resolve your pull request's merge conflicts accordingly.