zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

Published 20 hours ago • verified publisher icon zulip

Highlight narrowed stream/topic.

Open plugyawn opened this issue 1 year ago • 5 comments

What does this PR do? Solves #516. Highlights the current narrow.

Discussed here . Tested?

  • [x] Manually
  • [x] Existing tests (adapted, if necessary)
  • [x] Passed linting & tests (each commit)

Commit flow

  • first commit sets theme for zt_dark. Will rebase and change for other themes.
  • second commit sets functions for highlighting button
  • third commit is for model.py highlight whenever narrow_to is called.

Notes & Questions

  • Crashes when non-stream narrows are triggered (will fix, is fixed in last WIP PR)
  • topics are not highlighted yet.
  • Is the issue on linux systems fixed (related to second commit).

Visual changes image

plugyawn avatar Jul 28 '22 00:07 plugyawn

Formatting changes.

plugyawn avatar Aug 06 '22 03:08 plugyawn

@plugyawn Also as I mentioned elsewhere, please do your best to keep the linters and tests passing. The linting is normally easily fixed with black or make fix.

Were the AttributeErrors you were trying to fix coming from the tests?

neiljp avatar Aug 07 '22 19:08 neiljp

Removed the redundant code.

plugyawn avatar Aug 08 '22 05:08 plugyawn

@plugyawn Also as I mentioned elsewhere, please do your best to keep the linters and tests passing. The linting is normally easily fixed with black or make fix.

Were the AttributeErrors you were trying to fix coming from the tests?

Did the linting just now, sorry!

Yep, the AttributeErrrors are coming from the tests, not sure why.

plugyawn avatar Aug 10 '22 09:08 plugyawn

@plugyawn Also as I mentioned elsewhere, please do your best to keep the linters and tests passing. The linting is normally easily fixed with black or make fix. Were the AttributeErrors you were trying to fix coming from the tests?

Did the linting just now, sorry!

Yep, the AttributeErrrors are coming from the tests, not sure why.

Do you think shifting code to core.py would resolve these errors?

plugyawn avatar Aug 10 '22 09:08 plugyawn

Heads up @plugyawn, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Feb 24 '23 21:02 zulipbot

Closing in favor of rebased/readjusted version of later version of this PR, ie. #1334.

neiljp avatar Apr 22 '24 21:04 neiljp