zulip-terminal
zulip-terminal copied to clipboard
Add remaining type annotations to tests
This was started last Summer and is now mostly complete (see exclusions in tools/run-mypy
) 🎉
@prah23 Unsure if you will have time to follow-up with this, but also mentioning since you completed most of the prior work on this :+1:
Anyone taking this up (if @prah23 is not) will need to examine test files that are annotated for comparison and add them to one file at a time, enabling checking by removing the related exclusion.
Hello @zulip/server-refactoring members, this issue was labeled with the "area: refactoring" label, so you may want to check it out!
@neiljp Could you explain this a little further? I'd like to take this up.
@zulipbot claim
Hello @DaveOkpare!
Thanks for your interest in Zulip! You have attempted to claim an issue without the label "help wanted". You can only claim and submit pull requests for issues with the help wanted label.
If this is your first time here, we recommend reading our guide for new contributors before getting started.
Hi @neiljp can I take model/test_model.py
or
ui/test_ui_tools.py
?
@DaveOkpare Apologies for the slow response, but either file should be good - though both are quite large! If you wish to take this up, you might wish to follow #1337, which is specific to another file, but could provide useful directions.