zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

Show detected platform on startup and in About popup

Open plugyawn opened this issue 2 years ago • 2 comments

What does this PR do? Shows the detected platform on startup and in the About pop-up.

Tries to fix #1216.

Tested?

  • [x] Manually
  • [ ] Existing tests (adapted, if necessary)
  • [x] New tests added (for any new behavior)
  • [x] Passed linting & tests (each commit)

Commit flow

  • Add platform information on startup
  • Add platform information to About menu

Notes & Questions

Interactions

Visual changes image image

plugyawn avatar May 06 '22 14:05 plugyawn

Hello @plugyawn, it seems like you have referenced #1216 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #1216..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

To learn how to write a great commit message, please refer to our guide.

zulipbot avatar May 06 '22 14:05 zulipbot

@plugyawn Thanks for adding this, when ready it should be helpful for debugging in future 👍

Generally it may be useful to use something along the lines of Detected Platform instead of the 'Running' and 'Platform' you currently have, both for consistency, and since this is what ZT determines is the platform - we can't know for sure.

This doesn't currently address the idea of showing extra text if the platform is unsupported, from the original issue; you didn't mention skipping it for now in the PR description, so I assume you missed that.

I think I mentioned this in another PR review, but I'd recommend reading your PRs in GitHub and maybe also something like tig or another local viewer, to ensure that the commit text and contents looks like what you'd expect.

I missed the part about checking if the platform is unsupported, sorry -- I'm adding it right now.

plugyawn avatar May 08 '22 10:05 plugyawn

Heads up @plugyawn, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Feb 24 '23 21:02 zulipbot

@plugyawn Thanks for your work on this :+1: I recently merged #1435, which includes the About popup element, so I'm closing this now.

neiljp avatar Nov 06 '23 23:11 neiljp