zulip-terminal
zulip-terminal copied to clipboard
zulip
Display 'Message sent outside current narrow' when narrowing from all_messages and all_PMs.
Follow up PR #1194
What does this PR do?
This PR displays Message sent outside current narrow even if narrowing from all_messages or all_PMs
Tested?
- [x] Manually
- [x] Existing tests (adapted, if necessary)
- [ ] New tests added (for any new behavior)
- [x] Passed linting & tests (each commit)
Commit flow
Notes & Questions
Interactions
CZO - https://chat.zulip.org/#narrow/stream/206-zulip-terminal/topic/.E2.9C.94.20Support.20'Narrow.20to.20current.20compose.20box.20recipient'.20.23T1194
Cases for showing success message - https://github.com/zulip/zulip-terminal/pull/1194#discussion_r851485357
Visual changes
From #1194:
However, my remaining query here is whether we want to customize this logic/message a little further: - in all-messages narrow, we never see this, but may still want to go to the conversation - in stream (or all-PM) narrows which hold the message, we may also still want to go to the conversation - if a message is outside the narrow, we always want to show this
I may not have been clear in this comment, but what I meant is that the two messages are not necessarily correlated since the conditions vary:
- we still want the 'outside of narrow' behavior to stay the same
- we want to also show the hint if not fully narrowed, ie. what the shortcut would do (though this could become too much, we'll see)
@srdeotarse Left messages in stream for discussion. Also please address comments in a PR via changes or comments, or discuss in stream and reach a conclusion, before requesting review again :)
Heads up @srdeotarse, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.
