zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

views: Add footer to StreamsView and TopicsView

Open plugyawn opened this issue 2 years ago • 6 comments

What does this PR do? Added the shortcut hint for displaying Topics to the Streams Panel and a hint to get back to Streams in the Topics Panel.

Associated with #1190. Discussed on CZO at Stream/topic toggle hint?

Tested?

  • [x] Manually
  • [x] Existing tests (adapted, if necessary)
  • [ ] New tests added (for any new behavior)
  • [x] Passed linting & tests (each commit)

Commit flow

  • first commit adds the footer for the hints.
  • upcoming commit will add functionality for hint to only appear when cursor is in the panel.

Notes & Questions

  • Still shows hint even when not in the left panel, causing probable misunderstanding about where one has to press t, so have to fix that.

Visual changes Screenshot 2022-04-15 at 4 28 32 AM

plugyawn avatar Apr 14 '22 22:04 plugyawn

@plugyawn Thanks for exploring this :+1: See my thoughts in the stream, since this is mainly visual so we may want to discuss rather than focus on implementation.

neiljp avatar Apr 15 '22 06:04 neiljp

@neiljp implemented the theming change. Is it clearer to look at now?

plugyawn avatar Apr 16 '22 14:04 plugyawn

@zulipbot add "PR needs review"

plugyawn avatar Apr 17 '22 06:04 plugyawn

Feedback was given in the stream.

neiljp avatar Apr 17 '22 18:04 neiljp

@plugyawn You didn't change the labels on this, though have pushed since we last reviewed. I left a note in the stream.

neiljp avatar May 11 '22 00:05 neiljp

@plugyawn You didn't change the labels on this, though have pushed since we last reviewed. I left a note in the stream.

Oh, I just fixed the commit text for the PR, didn't add anything new, so I didn't change the labels.

plugyawn avatar May 12 '22 20:05 plugyawn

Heads up @plugyawn, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Apr 17 '24 23:04 zulipbot