zulip-terminal icon indicating copy to clipboard operation
zulip-terminal copied to clipboard

Check formatting of markdown in notifications

Open neiljp opened this issue 3 years ago • 7 comments

Following #1173 it would be useful to look through other markdown in Zulip and see how it is output in notifications, and attempt to improve it if possible.

Possible issues:

  • realm emoji?
  • tables (also an issue in regular zulip notifications?)
  • rules (also in zulip?)
  • ...

neiljp avatar Mar 21 '22 01:03 neiljp

Hello @zulip/server-notifications members, this issue was labeled with the "area: notifications" label, so you may want to check it out!

zulipbot avatar Mar 21 '22 02:03 zulipbot

@zulipbot claim.

@neiljp There's also issues with the \me mention, time, tasks, in addition to tables, rules, etc, as you mentioned. Would appreciate advice on how to resolve the time and tasks problems

plugyawn avatar Mar 31 '22 12:03 plugyawn

Welcome to Zulip, @plugyawn! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-terminal/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

zulipbot avatar Mar 31 '22 12:03 zulipbot

Fixed tables (with spaces and line-breaks), bullets, and emojis. Fixed linting issues.

plugyawn avatar Apr 03 '22 05:04 plugyawn

Hello @plugyawn, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

zulipbot avatar Apr 13 '22 08:04 zulipbot

@zulipbot claim

plugyawn avatar Apr 18 '22 10:04 plugyawn

@plugyawn You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

zulipbot avatar Apr 28 '22 15:04 zulipbot