zulip-terminal
zulip-terminal copied to clipboard
Improve focus highlighting in ZT.
What does this PR do?
This PR improves focus highlighting of buttons and boxes in ZT using AttrMap's focus_map feature.
This is implemented using a function create_focus_map
in themes.py
which is used as required
at runtime.
Tested?
- [x] Manually
- [x] Existing tests (adapted, if necessary)
- [x] New tests added (for any new behavior)
- [x] Passed linting & tests (each commit)
Commit flow
First commit is a refactor to handle stream color in 16color better
Second commit creates the function create_focus_map
which is used in subsequent commits.
Notes & Questions
Haven't written the commit description in detail, will update them soon Interactions
Waiting on #1088
@Rohitth007 Now that #1088 is merged, let's reconsider this, which was based on top of it :+1:
Heads up @Rohitth007, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main
branch and resolve your pull request's merge conflicts accordingly.