deps: Upgrade @react-navigation/{bottom,material-top}-tabs to 6.x

Open chrisbobbe opened this issue 10 months ago • 2 comments

The @react-navigation/material-top-tabs upgrade is done to get us off of react-native-reanimated, which should help us with

#5847

Then the @react-navigation/bottom-tabs upgrade was done because I was optimistic about swiftly finishing

#4936

. But I didn't manage to finish that off; it turned out to be more work than I have time for right now (in particular, upgrading @react-navigation/native and @react-navigation/stack). But the bottom-tabs upgrade, included here, should be ready to go.

Screenshots coming, to demonstrate that the appearance doesn't change except in one small way where we were forced to make an adjustment:

share-to: Move ScrollView inward, to ShareTo{Stream,Pm} tabs

Related: #5847 Fixes-partly: #4936

Apr 15 '24 23:04 chrisbobbe

I took screenshots on my iPhone yesterday, and I forgot which ones were "before" and which ones were "after" shots. I'll include both sets anyway and call them "A" and "B". If we spot important differences in how the UI looks between A and B, I can find out which is "before" and "after" by building the app again. But I think I can save quite a bit of time by just posting the ones I have now.