zulip-mobile icon indicating copy to clipboard operation
zulip-mobile copied to clipboard

Warn clearly when notifications disabled by F-Droid build

Open gnprice opened this issue 1 year ago • 7 comments

The F-Droid build of the app removes all support for notifications.

Some users have a setup where notifications would work just fine, but end up installing the F-Droid build. They are then surprised when notifications don't work. Two reports of this: https://github.com/zulip/zulip-mobile/issues/3838#issuecomment-1479613658 and previously in chat. In both cases, using our own published APK from https://github.com/zulip/zulip-mobile/releases solved the problem.

We recently added functionality to help debug when notifications aren't working, and to warn when we detect a situation where they won't work. We should extend that functionality so that it detects when notification support has been removed in the way that F-Droid removes it, and gives a more helpful message.

gnprice avatar Mar 24 '23 03:03 gnprice

@adrienneteicher, you reported at https://github.com/zulip/zulip-mobile/issues/3838#issuecomment-1479613658 that you weren't getting notifications, and helpfully provided the debugging information from our notification diagnostics screen.

Was the app showing you a warning about notifications that pointed you toward that screen? Do you recall what the warning, or the screen itself, was saying?

I'm curious because I'd like to better understand the current state of what we're showing here, in order to help design something that will be as usefully informative as possible for other people running into the same problem.

gnprice avatar Mar 24 '23 03:03 gnprice

Screenshot_20230324-100628 Screenshot_20230324-100636

Here are screenshots.

Then you get the error message I pasted in the other thread that asks you to contact support.

Thanks

adrienneteicher avatar Mar 24 '23 10:03 adrienneteicher

Thanks @adrienneteicher! Very helpful.

gnprice avatar Mar 25 '23 00:03 gnprice

What's a good message to the user explaining that the app they are using was built without notification support?

chrisbobbe avatar Mar 28 '23 00:03 chrisbobbe

I think there are two possibilities.

  1. A text which says "The f-droid build you are using does not support notifications. If your device supports GCM please download the Zulip client from the play store or from our website to enable notifications (links)."

  2. Is it necessary to disable notifications in the F-droid build? Why not just a message which says "The Zulip client depends on GCM to provide notifications. If your device does not have Google Play Services installed or a compatible alternative you will not see any notifications."

Adrienne Teicher Sound Designer / Somatic Performer Web: www.adrienneteicher.com[https://www.adrienneteicher.com/] www.hyenaz.com[https://www.hyenaz.com/]

28 Mar 2023 02:39:05 Chris Bobbe @.***>:

What's a good user-facing message explaining that the app their using was built without notification support?

— Reply to this email directly, view it on GitHub[https://github.com/zulip/zulip-mobile/issues/5693#issuecomment-1486045675], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AGYIPIBFPQALOBTFAZQ3FQDW6IXKPANCNFSM6AAAAAAWGA35JE]. You are receiving this because you were mentioned.[Tracking image][https://github.com/notifications/beacon/AGYIPIBOJUD7GQWS56676EDW6IXKPA5CNFSM6AAAAAAWGA35JGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSYSNA6W.gif]

adrienneteicher avatar Mar 28 '23 09:03 adrienneteicher

@adrienneteicher Compiling without GCM (or any proprietary libraries in general) is a requirement for addition to the F-Droid repository imposed by the maintainers. See the inclusion policy.

sevmonster avatar May 27 '23 12:05 sevmonster

Just ran into the same issue 2 days ago, which was luckily resolved quickly by @chrisbobbe through the support email channel.

Some extra info in the settings screen next to the App version, or as part of the notification screen would have saved everyone's time.

schewara avatar Dec 16 '23 19:12 schewara