zulip-desktop
zulip-desktop copied to clipboard
zulip
UI: Reconnect network page imporved.
What's this PR do? Improves the design alignment of network reconnect page.
Any background context you want to provide? Fixes #862
Screenshots?
You have tested this PR on:
- [ ] Windows
- [ ] Linux/Ubuntu
- [x] macOS
Checkout comments on #872. Try to find some graphics or maybe change the background color - a darker colour which could say there is connectivity error !?!
Checkout comments on #872. Try to find some graphics or maybe change the background color - a darker colour which could say there is connectivity error !?!
Yeah i had read it. should i make the background darker ? because using any random image from internet could lead to copyright issue that is the reason i preferred using the old one.
@samyakgaur before opening a PR please discuss the approach, UI changes etc with the community on czo. This will save a lot of your time.
@samyakgaur before opening a PR please discuss the approach, UI changes etc with the community on czo. This will save a lot of your time.
Yes @akashnimare i had done that but didn’t get any reply so i moved forward with this approach. Not an issue ill ask once again :)
@samyakgaur are you up for making the above changes? Once done, we can merge.
@samyakgaur are you up for making the above changes? Once done, we can merge.
@akashnimare sorry, almost forgot about this PR. will make the following changes and commit it.
Heads up @samyakgaur, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.
